Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CreateThread to avoid manual try-catch #1302

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Add CreateThread to avoid manual try-catch #1302

merged 4 commits into from
Mar 9, 2023

Conversation

PragmaTwice
Copy link
Member

Add CreateThread, ThreadJoin and ThreadDetach to wrap std::thread operations, to avoid manual try-catch.

@PragmaTwice PragmaTwice requested review from git-hulk and torwig March 8, 2023 15:24
torwig
torwig previously approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

git-hulk
git-hulk previously approved these changes Mar 9, 2023
View reviewed changes
@PragmaTwice PragmaTwice dismissed stale reviews from git-hulk and torwig via e0e9436 March 9, 2023 04:43
@PragmaTwice PragmaTwice requested review from git-hulk and torwig March 9, 2023 04:43
@PragmaTwice
Copy link
Member Author

Thanks all. Merging...

@PragmaTwice PragmaTwice merged commit d48edac into apache:unstable Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caipengbo caipengbo caipengbo approved these changes

@torwig torwig torwig approved these changes

@git-hulk git-hulk Awaiting requested review from git-hulk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PragmaTwice @git-hulk @torwig @caipengbo